Issue 3116026: Unblacklist graphics_WebGLConformance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3116026: Unblacklist graphics_WebGLConformance. (Closed)

Created:
10 years, 4 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
zbehan

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Unblacklist graphics_WebGLConformance. zbehan has fixed this test, so we can unblacklist it now. BUG=chromium-os:5881 TEST=Checked that all autotests compile Change-Id: I32c445018f270009bfc8751c6306c0fc53dcecbf

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	autotest	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zbehan

10 years, 4 months ago (2010-08-20 03:09:51 UTC) #2

LGTM, thanks!

On Thu, Aug 19, 2010 at 8:01 PM, <davidjames@chromium.org> wrote:

> Reviewers: zbehan,
>
> Description:
> Unblacklist graphics_WebGLConformance.
>
> zbehan has fixed this test, so we can unblacklist it now.
>
> BUG=chromium-os:5881
> TEST=Checked that all autotests compile
>
> Change-Id: I32c445018f270009bfc8751c6306c0fc53dcecbf
>
> Please review this at http://codereview.chromium.org/3116026/show
>
> SVN Base: http://src.chromium.org/git/crosutils.git
>
> Affected files:
>  M autotest
>
>
> Index: autotest
> diff --git a/autotest b/autotest
> index
>
eefcf0f268eeecbbe824db9c7388162ec41ca4f8..e5065950d718397d2c9d617061ab330f9b112b4e
> 100755
> --- a/autotest
> +++ b/autotest
> @@ -155,7 +155,6 @@ def build_autotest(options):
>   else:
>     blacklist = []
>
> -  blacklist.append("graphics_WebGLConformance")
>   all_tests = ('compilebench,dbench,disktest,fsx,hackbench,iperf,netperf2,'
>                'netpipe,unixbench')
>   site_tests = '../third_party/autotest/files/client/site_tests'
>
>
>

Expand Messages | Collapse Messages