Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 3116025: Added new commands and reactivated full rebuild after fixing for ARM ebuild. (Closed)

Created:
10 years, 4 months ago by Luigi Semenzato
Modified:
9 years, 7 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Base URL:
ssh://git@chromiumos-git/vboot_reference.git
Visibility:
Public.

Description

Added new commands and reactivated full rebuild after fixing for ARM ebuild.

Patch Set 1 #

Total comments: 1

Patch Set 2 : refactor getflags #

Total comments: 3

Patch Set 3 : move to new build flow (no changes expected) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -53 lines) Patch
M Makefile View 1 chunk +2 lines, -1 line 0 comments Download
M firmware/lib/tpm_lite/include/tlcl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M firmware/lib/tpm_lite/include/tlcl_structures.h View 1 chunk +5 lines, -0 lines 0 comments Download
M firmware/lib/tpm_lite/include/tss_constants.h View 1 3 chunks +27 lines, -13 lines 0 comments Download
M firmware/lib/tpm_lite/tlcl.c View 1 2 chunks +41 lines, -18 lines 0 comments Download
M firmware/stub/include/tpmextras.h View 2 chunks +5 lines, -8 lines 0 comments Download
M firmware/stub/tpm_lite_stub.c View 1 1 chunk +1 line, -1 line 0 comments Download
M firmware/version.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/tpm_lite/earlyextend.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/earlynvram.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/earlynvram2.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/fastenable.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/globallock.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/readonly.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/redefine.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/spaceperm.c View 1 chunk +0 lines, -1 line 0 comments Download
M tests/tpm_lite/writelimit.c View 1 chunk +0 lines, -1 line 0 comments Download
M utility/Makefile View 2 chunks +2 lines, -1 line 0 comments Download
M utility/tlcl_generator.c View 3 chunks +21 lines, -1 line 0 comments Download
M utility/tpmc.c View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Luigi Semenzato
I've added a couple of extra commands which I need in the "everything is properly ...
10 years, 4 months ago (2010-08-19 23:33:27 UTC) #1
Luigi Semenzato
http://codereview.chromium.org/3116025/diff/2001/3006 File firmware/stub/include/tpmextras.h (right): http://codereview.chromium.org/3116025/diff/2001/3006#newcode18 firmware/stub/include/tpmextras.h:18: #define TPM_ALL_LOCALITIES (TPM_LOC_ZERO | TPM_LOC_ONE | TPM_LOC_TWO \ I ...
10 years, 4 months ago (2010-08-20 17:11:21 UTC) #2
Luigi Semenzato
http://codereview.chromium.org/3116025/diff/2001/3009 File tests/tpm_lite/earlyextend.c (left): http://codereview.chromium.org/3116025/diff/2001/3009#oldcode12 tests/tpm_lite/earlyextend.c:12: #include <tss/tcs.h> This is the only change in all ...
10 years, 4 months ago (2010-08-20 17:12:20 UTC) #3
Randall Spangler
10 years, 4 months ago (2010-08-23 21:42:11 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698