Issue 3116014: Add method to get random bytes from the TPM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3116014: Add method to get random bytes from the TPM. (Closed)

Created:
10 years, 4 months ago by fes

Modified:
9 years, 7 months ago

Reviewers:
seano, Will Drewry

CC:
chromium-os-reviews_chromium.org

Base URL:
http://src.chromium.org/git/tpm_init.git

Visibility:
Public.

Description

Add method to get random bytes from the TPM. Change-Id: I66d8a746be5add2d277e2a0783c562206084fcb4 BUG=227 TEST=manual

Patch Set 2 : Make sure to free the TSS-allocated buffer. #

Total comments: 2

Patch Set 3 : Change int to size_t. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
M	tpm.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tpm.cc	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	tpm_init.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	tpm_init.cc	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

seano

LGTM (This is my first review of a CL in this repo, so I may ...

10 years, 4 months ago (2010-08-23 13:46:44 UTC) #2

Will Drewry

One nit, but otherwise looks good. http://codereview.chromium.org/3116014/diff/3001/4001 File tpm.cc (right): http://codereview.chromium.org/3116014/diff/3001/4001#newcode603 tpm.cc:603: SecureBlob random(length); Doesn't ...

10 years, 4 months ago (2010-08-23 15:28:21 UTC) #3

fes

http://codereview.chromium.org/3116014/diff/3001/4001 File tpm.cc (right): http://codereview.chromium.org/3116014/diff/3001/4001#newcode603 tpm.cc:603: SecureBlob random(length); Parameter changed to size_t.

10 years, 4 months ago (2010-08-23 20:34:38 UTC) #4

LGTM