Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 3115023: Enable spdy to 95%, npn only to 5%. (Closed)

Created:
10 years, 4 months ago by lzheng
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable spdy to 95%, npn only to 5%. BUG=48964 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56915

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/browser/browser_main.cc View 1 2 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
lzheng
Enable spdy to 95%, npn-http to 5%. The npn-http will help to collect control stats ...
10 years, 4 months ago (2010-08-20 17:59:44 UTC) #1
mbelshe
10 years, 4 months ago (2010-08-20 20:55:42 UTC) #2
lgtm

On Fri, Aug 20, 2010 at 10:59 AM, <lzheng@chromium.org> wrote:

> Reviewers: Mike Belshe,
>
> Message:
> Enable spdy to 95%, npn-http to 5%.
>
> The npn-http will help to collect control stats for http (when later
> alternate
> protocol is used) and https.
>
> Description:
> Enable spdy to 95%, npn only to 5%.
>
> Please review this at http://codereview.chromium.org/3115023/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/browser_main.cc
>
>
> Index: chrome/browser/browser_main.cc
> ===================================================================
> --- chrome/browser/browser_main.cc      (revision 56881)
> +++ chrome/browser/browser_main.cc      (working copy)
> @@ -344,15 +344,8 @@
>     const FieldTrial::Probability kSpdyDivisor = 1000;
>     // To enable 100% npn_with_spdy, set npnhttp_probability = 0 and set
>     // npnspdy_probability = FieldTrial::kAllRemainingProbability.
> -    // To collect stats, make sure that FieldTrial are distributed among
> -    // all the three groups:
> -    // npn_with_spdy : 50%, npn_with_http : 25%, default (no npn, no
> spdy): 25%.
> -    // a. npn_with_spdy and default: these are used to collect stats for
> -    //    alternate protocol with spdy vs. no alternate protocol case.
> -    // b. npn_with_spdy and npn_with_http: these are used to collect stats
> for
> -    //    https vs. https over spdy case.
> -    FieldTrial::Probability npnhttp_probability = 250;
> -    FieldTrial::Probability npnspdy_probability = 500;
> +    FieldTrial::Probability npnhttp_probability = 50;
> +    FieldTrial::Probability npnspdy_probability = 950;
>     scoped_refptr<FieldTrial> trial =
>         new FieldTrial("SpdyImpact", kSpdyDivisor);
>     // npn with only http support, no spdy.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698