Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 3115020: Fixes race condition that could result in a tab prematurely (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_view_host.cc
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc
index 0ba65d66c207139841a9875880d6c08576c64673..6eb899956513ca59da6f4daaf870fe3c1c4e5e10 100644
--- a/chrome/browser/renderer_host/render_view_host.cc
+++ b/chrome/browser/renderer_host/render_view_host.cc
@@ -243,6 +243,10 @@ void RenderViewHost::Navigate(const ViewMsg_Navigate_Params& params) {
DCHECK(!suspended_nav_message_.get());
suspended_nav_message_.reset(nav_message);
} else {
+ // Unset this, otherwise if true and the hang monitor fires we'll
+ // incorrectly close the tab.
+ is_waiting_for_unload_ack_ = false;
+
Send(nav_message);
// Force the throbber to start. We do this because WebKit's "started
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/browser/renderer_host/test/render_view_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698