Issue 3115020: Fixes race condition that could result in a tab prematurely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3115020: Fixes race condition that could result in a tab prematurely (Closed)

Created:
10 years, 4 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Fixes race condition that could result in a tab prematurely closing. Here's the sequence that triggers the closing: . go to a page. . go to a new page, preferably one that takes a while to resolve, such as one on a site that doesn't exist. . After this step is_waiting_for_unload_ack_ has been set to true on the first RVH. . click stop before the page has been commited. . click reload. . is_waiting_for_unload_ack_ is still true, and the if the hang monitor fires the tab gets closed. I've changed the code to always set is_waiting_for_unload_ack_ when we initiate a load. BUG=52003 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56804

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -0 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/test/render_view_host_unittest.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages