Issue 3115014: Revert 56384 - Don't resolve IP literals....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3115014: Revert 56384 - Don't resolve IP literals.... (Closed)

Created:
10 years, 4 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 56384 - Don't resolve IP literals. For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache. BUG=39830 TEST=unit tests, new and old Review URL: http://codereview.chromium.org/3023048 TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56385

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -131 lines)			Patch
M	chrome/browser/net/predictor_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/address_list.h	View	3 chunks	+14 lines, -6 lines	0 comments	Download
M	net/base/address_list.cc	View	2 chunks	+44 lines, -47 lines	0 comments	Download
M	net/base/address_list_unittest.cc	View	5 chunks	+11 lines, -51 lines	0 comments	Download
M	net/base/host_resolver_impl.cc	View	2 chunks	+2 lines, -17 lines	0 comments	Download
M	net/base/host_resolver_impl_unittest.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/base/mock_host_resolver.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	net/socket/ssl_client_socket_unittest.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)