Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: firmware/lib/include/rollback_index.h

Issue 3114013: Change rollback interface so kernel/firmware version numbers are (Closed) Base URL: ssh://gitrw.chromium.org/vboot_reference.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | firmware/lib/rollback_index.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: firmware/lib/include/rollback_index.h
diff --git a/firmware/lib/include/rollback_index.h b/firmware/lib/include/rollback_index.h
index f13b6ede0c35ab4dd8b79fb9d41c6be355deb005..d3a49ba60980dcbd5e95b36e21985227db24e01c 100644
--- a/firmware/lib/include/rollback_index.h
+++ b/firmware/lib/include/rollback_index.h
@@ -89,13 +89,10 @@ Call from LoadKernel()
/* Setup must be called. Pass developer_mode=nonzero if in developer
* mode. */
-/* TODO: use a 32-bit version instead of 2 version pieces */
-uint32_t RollbackFirmwareSetup(int developer_mode, uint16_t* key_version,
- uint16_t* version);
+uint32_t RollbackFirmwareSetup(int developer_mode, uint32_t* version);
/* Write may be called if the versions change */
-/* TODO: use a 32-bit version instead of 2 version pieces */
-uint32_t RollbackFirmwareWrite(uint16_t key_version, uint16_t version);
+uint32_t RollbackFirmwareWrite(uint32_t version);
/* Lock must be called */
uint32_t RollbackFirmwareLock(void);
@@ -111,9 +108,8 @@ uint32_t RollbackKernelRecovery(int developer_mode);
/* Read and write may be called if not in developer mode. If called in
* recovery mode, the effect is undefined. */
-/* TODO: use a 32-bit version instead of 2 version pieces */
-uint32_t RollbackKernelRead(uint16_t* key_version, uint16_t* version);
-uint32_t RollbackKernelWrite(uint16_t key_version, uint16_t version);
+uint32_t RollbackKernelRead(uint32_t* version);
+uint32_t RollbackKernelWrite(uint32_t version);
/* Lock must be called. Internally, it's ignored in recovery mode. */
uint32_t RollbackKernelLock(void);
« no previous file with comments | « no previous file | firmware/lib/rollback_index.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698