Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 3112034: Attempting to re-land CL 3110006 which turned out to have ... (Closed)

Created:
10 years, 4 months ago by Ryan Hamilton
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Attempting to re-land CL 3110006 which turned out to have a memory leak. Add support for speaking SSL to an HTTP Proxy, to HttpProxyClientSocketPool (and friends) More information about an HTTPS Proxy can be found here: http://dev.chromium.org/spdy/spdy-proxy This implementation supports both http:// and https:// requests, as well as support for both Proxy and Server auth. BUG=29625 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57371

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+740 lines, -105 lines) Patch
M net/http/http_network_session.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 4 chunks +9 lines, -5 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 chunks +290 lines, -0 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 1 2 8 chunks +30 lines, -10 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 2 10 chunks +94 lines, -27 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 2 15 chunks +68 lines, -28 lines 0 comments Download
M net/http/http_stream_request.h View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M net/http/http_stream_request.cc View 1 2 7 chunks +58 lines, -32 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 2 chunks +57 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Hamilton
Hi Guys, I had a memory leak in my earlier CL. In hindsight it was ...
10 years, 4 months ago (2010-08-25 17:50:12 UTC) #1
vandebo (ex-Chrome)
LGTM Your try jobs failed because lkgr is before the revert. You can tell the ...
10 years, 4 months ago (2010-08-25 17:59:52 UTC) #2
rch (use chromium not google)
10 years, 4 months ago (2010-08-25 18:09:31 UTC) #3
Ah!  I'll give that a shot.  Thanks...

On Aug 25, 2010 10:59:53 AM PDT, vandebo <vandebo@chromium.org> wrote:
> LGTM
> Your try jobs failed because lkgr is before the revert. You can tell
> the try
> servers to use a different revision with -r.

Powered by Google App Engine
This is Rietveld 408576698