Issue 3112015: Customize Hebrew spellcheck word break iterator...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3112015: Customize Hebrew spellcheck word break iterator... (Closed)

Created:
10 years, 4 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Customize Hebrew spellcheck word break iterator 1. Treats ASCII double/single quoation marks between Hebrew letters as MidLetter for Hebrew spellchecker because they're commonly used in place of Geresh and Gershayim. 2. Pass through ASCII double/single quotation marks and Geresh and Gershayim in OutputHebrew. See http://www.unicode.org/reports/tr29/proposed.html (version 6.0.0.0 draft2) about Hebrew tailoring. This alone does not fix bug 22909 completely. This CL will be followed with an ICU data fix. BUG=22909 TEST=unit_tests --gtest_filter=SpellcheckWordIteratorTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57223

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -12 lines)			Patch
	M	chrome/renderer/spellchecker/spellcheck_worditerator.cc	View	1	5 chunks	+20 lines, -6 lines	0 comments	Download
	M	chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc	View		3 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

10 years, 4 months ago (2010-08-18 03:03:14 UTC) #2

LGTM. Thank you for your Hebrew fix.

Regards,

Hironori Bono

Expand Messages | Collapse Messages