Issue 3111030: New pyauto translate tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3111030: New pyauto translate tests. (Closed)

Created:
10 years, 4 months ago by Alyssa

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Paweł Hajdan Jr.

Visibility:
Public.

Description

New pyauto translate tests. Added new functional tests for translation and also cleaned up existing tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57192

Patch Set 1 : Initial #

Total comments: 4

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -31 lines)			Patch
	M	chrome/test/functional/translate.py	View		6 chunks	+97 lines, -31 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alyssa

http://codereview.chromium.org/3111030/diff/2001/3001 File chrome/test/functional/translate.py (left): http://codereview.chromium.org/3111030/diff/2001/3001#oldcode199 chrome/test/functional/translate.py:199: def testNeverTranslateLanguage(self): A test with the same name and ...

10 years, 4 months ago (2010-08-23 22:42:54 UTC) #1

Nirnimesh

10 years, 4 months ago (2010-08-24 01:23:19 UTC) #2

LGTM

http://codereview.chromium.org/3111030/diff/2001/3001
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3111030/diff/2001/3001#newcode326
chrome/test/functional/translate.py:326: for i in range(3):
replace i with '_' or 'unused' to avoid pychecker warnings

http://codereview.chromium.org/3111030/diff/2001/3001#newcode329
chrome/test/functional/translate.py:329: 
Shouldn't you check that the button shows up?

http://codereview.chromium.org/3111030/diff/2001/3001#newcode347
chrome/test/functional/translate.py:347: for i in range(3):
same comments as above

Expand Messages | Collapse Messages