Issue 3111024: Remove wstrings from bookmarks, part 9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3111024: Remove wstrings from bookmarks, part 9. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, Paweł Hajdan Jr.

Visibility:
Public.

Description

Remove wstrings from bookmarks, part 9. This actually converts TreeNodeModel::SetTitle(node, title); this is used by bookmarks. BUG=23581 TEST=builds nad passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57007

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -5 lines)			Patch
M	app/tree_model.h	View	4 chunks	+5 lines, -2 lines	0 comments	Download
M	app/tree_node_model.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/tree_node_model_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

I know you're dying to find out whether I remembered to update all the copyrights ...

10 years, 4 months ago (2010-08-21 23:36:52 UTC) #1

Miranda Callahan

10 years, 4 months ago (2010-08-22 00:03:28 UTC) #2

On 2010/08/21 23:36:52, viettrungluu wrote:
> I know you're dying to find out whether I remembered to update all the
> copyrights or not.

You could mix it up with an indentation error once in a while!
LGTM

Expand Messages | Collapse Messages