package_to_live script pushes binary emerge package to remote device

package_to_live script pushes binary emerge package to remote device

This script allows us to test packages on development boxes which
might be behind a firewall in a way that prevents use of "gmerge".
In this model, images are built locally and then pushed onto the
client.

TEST=run on wifi testbed
BUG=none

[Sam Leffler, 2010-08-19 17:46:38]

LGTM; your call if you want to address nits

http://codereview.chromium.org/3111018/diff/1/2
File bin/cros_package_to_live (right):

http://codereview.chromium.org/3111018/diff/1/2#newcode3
bin/cros_package_to_live:3: # Copyright (c) 2009 The Chromium OS Authors. All
rights reserved.
2010

http://codereview.chromium.org/3111018/diff/1/2#newcode35
bin/cros_package_to_live:35: rm -rf "${TMP}"
<blink> hopefully this is never run by root

http://codereview.chromium.org/3111018/diff/1/2#newcode86
bin/cros_package_to_live:86: remote_sh "mount -o remount,ro /" || /bin/true
would be nice to restore the mount state instead of blindly marking it ro

[Paul Stewart, 2010-08-19 18:12:32]

http://codereview.chromium.org/3111018/diff/1/2
File bin/cros_package_to_live (right):

http://codereview.chromium.org/3111018/diff/1/2#newcode3
bin/cros_package_to_live:3: # Copyright (c) 2009 The Chromium OS Authors. All
rights reserved.
On 2010/08/19 17:46:38, Sam Leffler wrote:
> 2010

Done.

http://codereview.chromium.org/3111018/diff/1/2#newcode35
bin/cros_package_to_live:35: rm -rf "${TMP}"
On 2010/08/19 17:46:38, Sam Leffler wrote:
> <blink> hopefully this is never run by root

Done.

http://codereview.chromium.org/3111018/diff/1/2#newcode86
bin/cros_package_to_live:86: remote_sh "mount -o remount,ro /" || /bin/true
On 2010/08/19 17:46:38, Sam Leffler wrote:
> would be nice to restore the mount state instead of blindly marking it ro

It would, but if anyone happens to be using the read-writiness of the
filesystem, the ro won't succeed anyway.

[sosa, 2010-08-19 18:27:15]

Doesn't this do the same thing as gmergefs?

[Vince Laviano, 2010-08-19 18:30:40]

LGTM, with some whitespace nits.

http://codereview.chromium.org/3111018/diff/7001/8001
File bin/cros_package_to_live (right):

http://codereview.chromium.org/3111018/diff/7001/8001#newcode40
bin/cros_package_to_live:40: 
extra space

http://codereview.chromium.org/3111018/diff/7001/8001#newcode58
bin/cros_package_to_live:58: 
extra space

[pstew1, 2010-08-19 18:31:47]

Pray tell, what is gmergefs?

--
Paul

On Thu, Aug 19, 2010 at 11:27 AM,  <sosa@chromium.org> wrote:
> Doesn't this do the same thing as gmergefs?
>
>
> http://codereview.chromium.org/3111018/show
>

[Paul Stewart, 2010-08-19 18:37:52]

http://codereview.chromium.org/3111018/diff/7001/8001
File bin/cros_package_to_live (right):

http://codereview.chromium.org/3111018/diff/7001/8001#newcode40
bin/cros_package_to_live:40: 
On 2010/08/19 18:30:40, Vince Laviano wrote:
> extra space

Done.

http://codereview.chromium.org/3111018/diff/7001/8001#newcode58
bin/cros_package_to_live:58: 
On 2010/08/19 18:30:40, Vince Laviano wrote:
> extra space

Done.

[sosa, 2010-08-19 18:53:04]

http://src.chromium.org/cgi-bin/gitweb.cgi?p=dev-util.git;a=blob_plain;f=gmer...

It's only different in that gmergefs treats the remote FS as another
root (uses --root from the host) rather than remotely calling ssh ->
gmerge.  This gets around issues where configs are different between
the host and target (i.e. packages.provided etc).  However, your
approach doesn't require Fuse.  Maybe we can combine later

On Thu, Aug 19, 2010 at 11:31 AM, Paul Stewart <pstew@google.com> wrote:
> Pray tell, what is gmergefs?
>
> --
> Paul
>
> On Thu, Aug 19, 2010 at 11:27 AM,  <sosa@chromium.org> wrote:
>> Doesn't this do the same thing as gmergefs?
>>
>>
>> http://codereview.chromium.org/3111018/show
>>
>

[sosa, 2010-08-19 18:54:03]

FYI it's documented here:
http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/helper-scripts.
 If you'd like other devs to use your script you should also add a
note about it here too :)

On Thu, Aug 19, 2010 at 11:52 AM, Chris Sosa <sosa@chromium.org> wrote:
>
http://src.chromium.org/cgi-bin/gitweb.cgi?p=dev-util.git;a=blob_plain;f=gmer...
>
> It's only different in that gmergefs treats the remote FS as another
> root (uses --root from the host) rather than remotely calling ssh ->
> gmerge.  This gets around issues where configs are different between
> the host and target (i.e. packages.provided etc).  However, your
> approach doesn't require Fuse.  Maybe we can combine later
>
> On Thu, Aug 19, 2010 at 11:31 AM, Paul Stewart <pstew@google.com> wrote:
>> Pray tell, what is gmergefs?
>>
>> --
>> Paul
>>
>> On Thu, Aug 19, 2010 at 11:27 AM,  <sosa@chromium.org> wrote:
>>> Doesn't this do the same thing as gmergefs?
>>>
>>>
>>> http://codereview.chromium.org/3111018/show
>>>
>>
>

[Sam Leffler, 2010-08-19 20:13:49]

I thought gmergefs was dead.

-Sam

On Thu, Aug 19, 2010 at 11:53 AM, Chris Sosa <sosa@chromium.org> wrote:

> FYI it's documented here:
>
> http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/helper-scripts
> .
>  If you'd like other devs to use your script you should also add a
> note about it here too :)
>
> On Thu, Aug 19, 2010 at 11:52 AM, Chris Sosa <sosa@chromium.org> wrote:
> >
>
http://src.chromium.org/cgi-bin/gitweb.cgi?p=dev-util.git;a=blob_plain;f=gmer...
> >
> > It's only different in that gmergefs treats the remote FS as another
> > root (uses --root from the host) rather than remotely calling ssh ->
> > gmerge.  This gets around issues where configs are different between
> > the host and target (i.e. packages.provided etc).  However, your
> > approach doesn't require Fuse.  Maybe we can combine later
> >
> > On Thu, Aug 19, 2010 at 11:31 AM, Paul Stewart <pstew@google.com> wrote:
> >> Pray tell, what is gmergefs?
> >>
> >> --
> >> Paul
> >>
> >> On Thu, Aug 19, 2010 at 11:27 AM,  <sosa@chromium.org> wrote:
> >>> Doesn't this do the same thing as gmergefs?
> >>>
> >>>
> >>> http://codereview.chromium.org/3111018/show
> >>>
> >>
> >
>

[sosa, 2010-08-19 20:46:42]

It stills works for items on the stateful partition .  There seems to
be another permissions issue with this and gmergefs so I won't say
anything more.  I would really like gmergefs to be used and thought
this is a big use case.  If I can fix the permissions issue, I'll come
back and attempt to merge these efforts.  Otherwise, I"ll deprecate
gmergefs.

On Thu, Aug 19, 2010 at 1:13 PM, Sam Leffler <sleffler@chromium.org> wrote:
> I thought gmergefs was dead.
> -Sam
>
> On Thu, Aug 19, 2010 at 11:53 AM, Chris Sosa <sosa@chromium.org> wrote:
>>
>> FYI it's documented here:
>>
>>
http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/helper-scripts.
>>  If you'd like other devs to use your script you should also add a
>> note about it here too :)
>>
>> On Thu, Aug 19, 2010 at 11:52 AM, Chris Sosa <sosa@chromium.org> wrote:
>> >
>> >
http://src.chromium.org/cgi-bin/gitweb.cgi?p=dev-util.git;a=blob_plain;f=gmer...
>> >
>> > It's only different in that gmergefs treats the remote FS as another
>> > root (uses --root from the host) rather than remotely calling ssh ->
>> > gmerge.  This gets around issues where configs are different between
>> > the host and target (i.e. packages.provided etc).  However, your
>> > approach doesn't require Fuse.  Maybe we can combine later
>> >
>> > On Thu, Aug 19, 2010 at 11:31 AM, Paul Stewart <pstew@google.com> wrote:
>> >> Pray tell, what is gmergefs?
>> >>
>> >> --
>> >> Paul
>> >>
>> >> On Thu, Aug 19, 2010 at 11:27 AM,  <sosa@chromium.org> wrote:
>> >>> Doesn't this do the same thing as gmergefs?
>> >>>
>> >>>
>> >>> http://codereview.chromium.org/3111018/show
>> >>>
>> >>
>> >
>
>