Add retry on svn cat.

Add retry on svn cat and use --non-interactive flag.

The svn server fails often, causing codereview.settings not being fetched. When no valid cached credential is found, codereview.settings wouldn't be fetched either.

Enforce LANGUAGE=en for odd systems like mine.

TEST=gcl should act better with unstable svn server or invalid cached credentials
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56700

[nsylvain, 2010-08-19 14:53:04]

http://codereview.chromium.org/3111016/diff/3001/4001
File gcl.py (right):

http://codereview.chromium.org/3111016/diff/3001/4001#newcode139
gcl.py:139: dir_info = SVN.CaptureInfo(".")
this might actually be what's failing. See comment below

http://codereview.chromium.org/3111016/diff/3001/4001#newcode147
gcl.py:147: for _ in range(5):
that's kind of ugly. Is it a real pattern or you invented that? If so, can we
just call it "i" and not use it?

http://codereview.chromium.org/3111016/diff/3001/4001#newcode155
gcl.py:155: SVN.RunAndFilterOutput(
I thought the problem is that you were running it in non-interactive mode, and
it did not ask for the new password (I assume the problem is that he changed his
password, and did not update the code before sending the gcl change)

Is it still a problem?

http://codereview.chromium.org/3111016/diff/3001/4001#newcode222
gcl.py:222: command,
i dont think that's what they meant when they said we should align stuff better.
this is ugly. Can you at least put command like "Popen(command," and then align
with command? I think it would fit.

[M-A Ruel, 2010-08-19 15:17:37]

Take another look

[nsylvain, 2010-08-19 15:47:07]

lgtm with nit

http://codereview.chromium.org/3111016/diff/6001/1002
File gcl.py (right):

http://codereview.chromium.org/3111016/diff/6001/1002#newcode154
gcl.py:154: ErrorExit('Your svn credentials expired. Please run svn log to '
what about svn ls ? Svn log is evil