gclient_utils.py - Issue 3110030: Fix for files not ending with \n, otherwise the last line would be ignored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_utils.py

Issue 3110030: Fix for files not ending with \n, otherwise the last line would be ignored. (Closed)

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient_utils.py

diff --git a/gclient_utils.py b/gclient_utils.py

index 1efa036f6e99b970dea91e4d6d0c3b96e368e90f..8506321c3d79e003a7c05158715d6ed268871d48 100644

--- a/gclient_utils.py

+++ b/gclient_utils.py

@@ -317,6 +317,10 @@ def SubprocessCallAndFilter(command,

last_flushed_at = time.time()

sys.stdout.flush()

in_byte = kid.stdout.read(1)

+ # Flush the rest of buffered output. This is only an issue with files not

+ # ending with a \n.

+ if len(in_line) and filter_fn:

+ filter_fn(in_line)

rv = kid.wait()

if rv:

« no previous file with comments | « no previous file | no next file » | no next file with comments »