Issue 3110027: Keep repo using http on incremental builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3110027: Keep repo using http on incremental builds (Closed)

Created:
10 years, 4 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git//crosutils.git

Visibility:
Public.

Description

Buildbots should not need to push changes unless they are a pre flight buildbot. TEST=Ran cbuildbot twice. BUG=5907

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
	M	bin/cbuildbot.py	View		2 chunks	+12 lines, -14 lines	1 comment	Download
	M	bin/cros_repo_sync_all.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

LGTM on the re-factoring but I disagree with the description. http://codereview.chromium.org/3110027/diff/1/2 File bin/cbuildbot.py (right): http://codereview.chromium.org/3110027/diff/1/2#newcode65 ...

10 years, 4 months ago (2010-08-19 22:57:07 UTC) #2

sosa

10 years, 4 months ago (2010-08-19 23:04:30 UTC) #3

Ah good call.  Will change description and commit.

On Thu, Aug 19, 2010 at 3:57 PM,  <msb@chromium.org> wrote:
> LGTM on the re-factoring but I disagree with the description.
>
>
> http://codereview.chromium.org/3110027/diff/1/2
> File bin/cbuildbot.py (right):
>
> http://codereview.chromium.org/3110027/diff/1/2#newcode65
> bin/cbuildbot.py:65: 'http://src.chromium.org/git'], cwd=buildroot)
> What this is doing is telling git to use ssh instead of http for
> pushing. It should have no impact on checkout (i.e. pulling) speed.
>
> http://codereview.chromium.org/3110027/show
>

Expand Messages | Collapse Messages