Issue 3110012: Provide a -update option to the AU client to allow synchronous updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3110012: Provide a -update option to the AU client to allow synchronous updates. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr, seano, ericli

Base URL:
http://src.chromium.org/git/update_engine.git

Visibility:
Public.

Description

Provide a -update option to the AU client to allow synchronous updates. This makes "update_engine_client -update" an easy replacement for memento_updater.sh from developer's standpoint. Also, remove currently unused flag force_update. BUG=5401 TEST=gmerged and tested the client on the device Change-Id: Ib9cc6d6de77d339f57059fb9470c838897149a4f

Patch Set 1 #

Total comments: 2

Patch Set 2 : review feedback -- document |op| #

Patch Set 3 : Remove redundant checks for FLAGS_update. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -14 lines)			Patch
	M	update_engine_client.cc	View	1 2	6 chunks	+57 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM http://codereview.chromium.org/3110012/diff/1/2 File update_engine_client.cc (right): http://codereview.chromium.org/3110012/diff/1/2#newcode73 update_engine_client.cc:73: bool GetStatus(string* op) { comment on what 'op' ...

10 years, 4 months ago (2010-08-13 00:03:05 UTC) #2

petkov

10 years, 4 months ago (2010-08-13 00:19:27 UTC) #3

Also removed some redundancy in the FLAGS_update checks.

Pushing...

http://codereview.chromium.org/3110012/diff/1/2
File update_engine_client.cc (right):

http://codereview.chromium.org/3110012/diff/1/2#newcode73
update_engine_client.cc:73: bool GetStatus(string* op) {
On 2010/08/13 00:03:05, adlr wrote:
> comment on what 'op' is for?

Done.

Expand Messages | Collapse Messages