Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 3110004: Revert 55507 - Start chromoting host in the service process though a method ... (Closed)

Created:
10 years, 4 months ago by Glen Murphy
Modified:
9 years, 5 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 55507 - Start chromoting host in the service process though a method call This change exposes method calls to configure the chromoting host and allow it to be started from a method. This will allow us to use IPC message to start the chromoting host. TEST=unit_tests --gtest_filter=ServiceProcess* BUG=50243, 50244 Review URL: http://codereview.chromium.org/3084024 TBR=hclam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -243 lines) Patch
M chrome/service/service_main.cc View 3 chunks +57 lines, -1 line 0 comments Download
M chrome/service/service_process.h View 4 chunks +6 lines, -44 lines 0 comments Download
M chrome/service/service_process.cc View 6 chunks +13 lines, -112 lines 0 comments Download
M chrome/service/service_process_unittest.cc View 1 chunk +1 line, -69 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/jingle_glue/jingle_client.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Glen Murphy
10 years, 4 months ago (2010-08-10 02:46:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698