More fun with detecting UAC. Reports in the field indicate that some computer...

More fun with detecting UAC. Reports in the field indicate that some computers have EnableLUA set to 2, which Vista treats as UAC 'on' but since our check checks for uac == 1 we think UAC is 'off'.

Changed the check to look for != 0 instead.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2330

[Peter Kasting, 2008-09-17 18:35:27]

http://codereview.chromium.org/3110/diff/1/2
File base/win_util.cc (right):

http://codereview.chromium.org/3110/diff/1/2#newcode331
Line 331: return (uac_enabled != 0);
Drive-by nit: a comment that users can set this to arbitrary values and Vista
treats anything non-zero as "on" might be useful, for preventing similar future
problems...

(Of course, I probably would have just returned !!uac_enabled or something, but
some people don't like that)

[Finnur, 2008-09-17 18:44:21]

Sure. I have added that as a comment.

On 2008/09/17 18:35:27, pkasting wrote:
> http://codereview.chromium.org/3110/diff/1/2
> File base/win_util.cc (right):
> 
> http://codereview.chromium.org/3110/diff/1/2#newcode331
> Line 331: return (uac_enabled != 0);
> Drive-by nit: a comment that users can set this to arbitrary values and Vista
> treats anything non-zero as "on" might be useful, for preventing similar
future
> problems...
> 
> (Of course, I probably would have just returned !!uac_enabled or something,
but
> some people don't like that)

[cpu_(ooo_6.6-7.5), 2008-09-17 20:48:44]

OK.