Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 3110: More fun with detecting UAC. Reports in the field indicate that some computer... (Closed)

Created:
12 years, 3 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

More fun with detecting UAC. Reports in the field indicate that some computers have EnableLUA set to 2, which Vista treats as UAC 'on' but since our check checks for uac == 1 we think UAC is 'off'. Changed the check to look for != 0 instead. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2330

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M base/win_util.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
12 years, 3 months ago (2008-09-17 18:30:05 UTC) #1
Peter Kasting
http://codereview.chromium.org/3110/diff/1/2 File base/win_util.cc (right): http://codereview.chromium.org/3110/diff/1/2#newcode331 Line 331: return (uac_enabled != 0); Drive-by nit: a comment ...
12 years, 3 months ago (2008-09-17 18:35:27 UTC) #2
Finnur
Sure. I have added that as a comment. On 2008/09/17 18:35:27, pkasting wrote: > http://codereview.chromium.org/3110/diff/1/2 ...
12 years, 3 months ago (2008-09-17 18:44:21 UTC) #3
cpu_(ooo_6.6-7.5)
12 years, 3 months ago (2008-09-17 20:48:44 UTC) #4
OK.

Powered by Google App Engine
This is Rietveld 408576698