Issue 3109023: autotest: Fix grab-buildbot in sync_build_test by gsdizing it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3109023: autotest: Fix grab-buildbot in sync_build_test by gsdizing it (Closed)

Created:
10 years, 4 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git//crosutils.git

Visibility:
Public.

Description

Fix grab-buildbot in sync_build_test by gsdizing it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b5ab343

Patch Set 1 #

Patch Set 2 : checkpoint #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -17 lines)			Patch
	M	sync_build_test.sh	View	1	9 chunks	+34 lines, -17 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 3 months ago (2010-09-24 21:35:37 UTC) #2

LGTM w/ a couple of suggestions.

http://codereview.chromium.org/3109023/diff/2001/3001
File sync_build_test.sh (right):

http://codereview.chromium.org/3109023/diff/2001/3001#newcode474
sync_build_test.sh:474: # Clear out the credentials so they can't be used later.
You should probably do this in the failure() function too.

http://codereview.chromium.org/3109023/diff/2001/3001#newcode497
sync_build_test.sh:497: echo "To run tests on a buildbot image, run setup_board
first."
die?

Expand Messages | Collapse Messages