New translate test for pyauto.

New translate test for pyauto.

New pyauto functional test for translate on history and downloads pages.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57065

[Alyssa, 2010-08-13 21:05:27]

http://codereview.chromium.org/3109017/diff/2001/3003
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3109017/diff/2001/3003#newcode388
chrome/test/functional/translate.py:388: """
This is now done in 3 files. Is it worth refactoring it into pyauto.py or a
subclass?

[Nirnimesh, 2010-08-13 22:18:16]

LGTM

http://codereview.chromium.org/3109017/diff/2001/3003
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3109017/diff/2001/3003#newcode388
chrome/test/functional/translate.py:388: """
On 2010/08/13 21:05:27, Alyssa wrote:
> This is now done in 3 files. Is it worth refactoring it into pyauto.py or a
> subclass?

I won't mind putting this function in pyauto.py, but make sure you fix the other
usages if you choose to do this

[Alyssa, 2010-08-16 23:29:07]

Do you want to take another look after the refactor? It turns out that the test
in omnibox.py was very different, so the new pyauto function is just used in
translate.py and downloads.py. Is it still worth it? If not, I'll remove the
Revision and commit.

[Nirnimesh, 2010-08-16 23:57:32]

Looks like even between these translate.py and downloads.py, the usage is
different, for which you use the remove flag. So the refactoring doesn't seem
clean to me. I'd say don't bother.

http://codereview.chromium.org/3109017/diff/15001/16003
File chrome/test/functional/downloads.py (right):

http://codereview.chromium.org/3109017/diff/15001/16003#newcode137
chrome/test/functional/downloads.py:137: shutil.rmtree(unicode(temp_dir))
This is out of the finally block. If the test above fails, it won't get called.

http://codereview.chromium.org/3109017/diff/15001/16005
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/3109017/diff/15001/16005#newcode250
chrome/test/pyautolib/pyauto.py:250: 
I'm not sure this should go in pyauto.py
Maybe in a new file shared across tests.
like: chrome/test/functional/_common.py