Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 3108050: Make hardware_Components test work on legacy BIOS (Closed)

Created:
10 years, 4 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Tom Wai-Hong Tam
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Make hardware_Components test work on legacy BIOS Skip execptions in hardware component detection and convert to property valuse. BUG=chromium-os:6115 TEST=manual Change-Id: I21e631b9a372a91875d78e7113e4576bf2216943

Patch Set 1 #

Total comments: 4

Patch Set 2 : modify according to reviewer's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M client/site_tests/hardware_Components/hardware_Components.py View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hung-Te
10 years, 4 months ago (2010-08-26 07:32:55 UTC) #1
Tom Wai-Hong Tam
http://codereview.chromium.org/3108050/diff/1/2 File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/3108050/diff/1/2#newcode286 client/site_tests/hardware_Components/hardware_Components.py:286: def force_get_property(self, propname): Please use a meaningful name for ...
10 years, 4 months ago (2010-08-26 18:32:04 UTC) #2
Hung-Te
10 years, 4 months ago (2010-08-27 02:08:15 UTC) #3
Hung-Te
http://codereview.chromium.org/3108050/diff/1/2 File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/3108050/diff/1/2#newcode286 client/site_tests/hardware_Components/hardware_Components.py:286: def force_get_property(self, propname): On 2010/08/26 18:32:04, Tom Wai-Hong Tam ...
10 years, 4 months ago (2010-08-27 02:08:46 UTC) #4
Tom Wai-Hong Tam
10 years, 4 months ago (2010-08-27 02:12:34 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698