Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6703)

Unified Diff: chrome/browser/resources/options/chromeos_language_options.js

Issue 3108032: Convert alert() to notification bar. (Closed)
Patch Set: Merge trunk Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/chromeos_language_options.js
diff --git a/chrome/browser/resources/options/chromeos_language_options.js b/chrome/browser/resources/options/chromeos_language_options.js
index 838615f5b18d84064c7ff3b5c3e31db19d42c729..6a8c70853e46c78858c5d833d3e6039b222c1ee7 100644
--- a/chrome/browser/resources/options/chromeos_language_options.js
+++ b/chrome/browser/resources/options/chromeos_language_options.js
@@ -412,8 +412,9 @@ cr.define('options', function() {
var languageCode = languageOptionsList.getSelectedLanguageCode();
// Don't allow removing the language if it's as UI language.
if (languageCode == templateData.currentUiLanguageCode) {
- // TODO(satorux): Show the message in a nicer way. See above.
- alert(localStrings.getString('this_language_is_currently_in_use'));
+ this.showNotification_(
+ localStrings.getString('this_language_is_currently_in_use'),
+ localStrings.getString('ok_button'));
return;
}
// Disable input methods associated with |languageCode|.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698