Issue 3108011: If ethernet is not available (i.e. no wired nic), don't show ethernet in stat...

Issue 3108011: If ethernet is not available (i.e. no wired nic), don't show ethernet in stat... (Closed)

Created:
10 years, 4 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
dhg

CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

If ethernet is not available (i.e. no wired nic), don't show ethernet in status menu, about:networks, and options pages. Also fixed a small issue where we should not be displaying "Other..." if wifi is disabled. BUG=chromium-os:5570 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55915

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -73 lines)			Patch
M	chrome/browser/chromeos/cros/network_library.cc	View		7 chunks	+21 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/internet_options_handler.cc	View	1	2 chunks	+29 lines, -22 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	1 2	7 chunks	+31 lines, -25 lines	1 comment	Download
M	chrome/browser/resources/options/chromeos_internet_options.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_internet_options.js	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_internet_options_page.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dhg

LGTM with a question. http://codereview.chromium.org/3108011/diff/11001/12003 File chrome/browser/chromeos/status/network_menu_button.cc (right): http://codereview.chromium.org/3108011/diff/11001/12003#newcode7 chrome/browser/chromeos/status/network_menu_button.cc:7: #include <algorithm> Whats this used ...

10 years, 4 months ago (2010-08-12 15:47:25 UTC) #2

Charlie Lee

Some of the math calls we were doing to calculate which icon to use is ...

10 years, 4 months ago (2010-08-12 19:47:34 UTC) #3

dhg

10 years, 4 months ago (2010-08-12 19:49:38 UTC) #4

ahhh.. ok

On Thu, Aug 12, 2010 at 12:47 PM,  <chocobo@chromium.org> wrote:
> Some of the math calls we were doing to calculate which icon to use is using
> that. When I ran lint, it complained about it. So I just added it. It's not
> related to anything I'm doing in this CL.
>
> On 2010/08/12 15:47:25, dhg wrote:
>>
>> LGTM with a question.
>
>> http://codereview.chromium.org/3108011/diff/11001/12003
>> File chrome/browser/chromeos/status/network_menu_button.cc (right):
>
>> http://codereview.chromium.org/3108011/diff/11001/12003#newcode7
>> chrome/browser/chromeos/status/network_menu_button.cc:7: #include
>> <algorithm>
>> Whats this used for?
>
>
>
> http://codereview.chromium.org/3108011/show
>

Expand Messages | Collapse Messages