Issue 3108010: Clean up some style violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3108010: Clean up some style violations. (Closed)

Created:
10 years, 4 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://src.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Clean up some style violations. Addressing comments from http://codereview.chromium.org/3151005/show, which has already been closed. Change-Id: Ibe314831ac0d757b29f4bc0f0aae1a8f700e169c

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -34 lines)			Patch
	M	utility/dev_sign_file.c	View		13 chunks	+33 lines, -34 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 4 months ago (2010-08-11 19:14:26 UTC) #2

LGTM

http://codereview.chromium.org/3108010/diff/1/2
File utility/dev_sign_file.c (right):

http://codereview.chromium.org/3108010/diff/1/2#newcode340
utility/dev_sign_file.c:340: /* NOTREACHED */
btw, i'm fine w/ having a return 1 here, which may be nice if gcc gives a
spurious warning. I was just thinking a comment may be nice to point out to
future humans that this code isn't executed.

Expand Messages | Collapse Messages