Chromium Code Reviews

Issue 3108004: Fix CPU profiler crash in start / stop sequence when non-existent name is passed (Closed)

Created:
10 years, 4 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
Reviewers:
Søren Thygesen Gjesse
CC:
v8-dev
Visibility:
Public.

Description

Fix CPU profiler crash in start / stop sequence when non-existent name is passed BUG=51594 TEST=test-cpu-profiler/CrashIfStoppingLastNonExistentProfile Committed: http://code.google.com/p/v8/source/detail?r=5230

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+32 lines, -24 lines)
M src/cpu-profiler.h View 1 chunk +1 line, -1 line 0 comments
M src/cpu-profiler.cc View 2 chunks +6 lines, -5 lines 0 comments
M src/profile-generator.h View 1 chunk +1 line, -4 lines 0 comments
M src/profile-generator.cc View 2 chunks +9 lines, -7 lines 0 comments
M src/profile-generator-inl.h View 1 chunk +0 lines, -7 lines 0 comments
M test/cctest/test-cpu-profiler.cc View 2 chunks +15 lines, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 4 months ago (2010-08-10 08:56:37 UTC) #1
Søren Thygesen Gjesse
10 years, 4 months ago (2010-08-10 11:57:09 UTC) #2
LGTM

Powered by Google App Engine