Adding json based tree open check.

Adding json based tree open check.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57438

[M-A Ruel, 2010-08-26 00:18:54]

lgtm with optional nit

http://codereview.chromium.org/3107038/diff/5001/6001
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/3107038/diff/5001/6001#newcode369
presubmit_canned_checks.py:369: try:
you could something like:
connection = input_api.urllib2.urlopen(url or json_url)
status = connection.read()
connection.close()
if json_url:
  status = input_api.json.loads(status)
  ...

ok that only saves 2 miserable line, feel free to ignore me.

http://codereview.chromium.org/3107038/diff/5001/6001#newcode374
presubmit_canned_checks.py:374: if not status['can_commit_freely']:
ahah that's cute

[bradn, 2010-08-26 00:22:24]

http://codereview.chromium.org/3107038/diff/5001/6001
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/3107038/diff/5001/6001#newcode369
presubmit_canned_checks.py:369: try:
On 2010/08/26 00:18:54, Marc-Antoine Ruel wrote:
> you could something like:
> connection = input_api.urllib2.urlopen(url or json_url)
> status = connection.read()
> connection.close()
> if json_url:
>   status = input_api.json.loads(status)
>   ...
> 
> ok that only saves 2 miserable line, feel free to ignore me.

I'm gonna keep it as I aspire to drop the old syntax once all downstream users
are switched. Added TODO.