Fix a crash where we are checking IsConnected(). If you look into the ...

net/http/http_stream_parser.cc

Index: net/http/http_stream_parser.cc
===================================================================
--- net/http/http_stream_parser.cc	(revision 57023)
+++ net/http/http_stream_parser.cc	(working copy)
@@ -579,7 +579,8 @@
 
 void HttpStreamParser::GetSSLInfo(SSLInfo* ssl_info) {
   if (request_->url.SchemeIs("https")) {
-    CHECK(connection_->socket()->IsConnected());
+    if (!connection_->socket() || !connection_->socket()->IsConnected())

[eroman, 2010/08/25 05:26:47]

we weren't previously checking to see if socket is non-NULL, under what
circumstances is that valid?

[Mike Belshe, 2010/08/25 06:22:32]

It's not really valid.  I was just making it the same as the check on line 593.

+      return;
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLInfo(ssl_info);
@@ -591,7 +592,6 @@
   if (request_->url.SchemeIs("https")) {
     if (!connection_->socket() || !connection_->socket()->IsConnected())
       return;
-    CHECK(connection_->socket()->IsConnected());
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLCertRequestInfo(cert_request_info);