Fix a crash where we are checking IsConnected(). If you look into the ...

net/http/http_stream_parser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_parser.h"
 
 #include "base/compiler_specific.h"
 #include "base/histogram.h"
 #include "net/base/auth.h"
 #include "net/base/io_buffer.h"
@@ skipping 561 matching lines @@
   return connection_->is_reused() ||
          reuse_type == ClientSocketHandle::UNUSED_IDLE;
 }
 
 void HttpStreamParser::SetConnectionReused() {
   connection_->set_is_reused(true);
 }
 
 void HttpStreamParser::GetSSLInfo(SSLInfo* ssl_info) {
   if (request_->url.SchemeIs("https")) {
-    CHECK(connection_->socket()->IsConnected());
+    if (!connection_->socket() || !connection_->socket()->IsConnected())

[eroman, 2010/08/25 05:26:47]

we weren't previously checking to see if socket is non-NULL, under what
circumstances is that valid?

[Mike Belshe, 2010/08/25 06:22:32]

It's not really valid.  I was just making it the same as the check on line 593.

+      return;
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLInfo(ssl_info);
   }
 }
 
 void HttpStreamParser::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   if (request_->url.SchemeIs("https")) {
     if (!connection_->socket() || !connection_->socket()->IsConnected())
       return;
-    CHECK(connection_->socket()->IsConnected());
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLCertRequestInfo(cert_request_info);
   }
 }
 
 }  // namespace net