Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 3107033: Remove the full codegen syntax checker completely but be... (Closed)

Created:
10 years, 4 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Søren Thygesen Gjesse, sgjesse
CC:
v8-dev
Visibility:
Public.

Description

Remove the full codegen syntax checker completely but be careful to avoid making code with loops run too slowly. Committed: http://code.google.com/p/v8/source/detail?r=5324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -470 lines) Patch
M src/ast.h View 4 chunks +5 lines, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +5 lines, -22 lines 0 comments Download
M src/full-codegen.h View 1 chunk +0 lines, -23 lines 0 comments Download
M src/full-codegen.cc View 2 chunks +1 line, -408 lines 0 comments Download
M src/parser.cc View 12 chunks +22 lines, -6 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 4 months ago (2010-08-24 08:39:48 UTC) #1
sgjesse_gmail.com
10 years, 4 months ago (2010-08-24 08:55:51 UTC) #2
LGTM!

Great to get rid of the syntax checker.

Powered by Google App Engine
This is Rietveld 408576698