Issue 3107031: entd: Restart on token init failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3107031: entd: Restart on token init failure (Closed)

Created:
10 years, 4 months ago by rginda

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, rginda, gauravsh

Base URL:
http://src.chromium.org/git/entd.git

Visibility:
Public.

Description

entd: Restart on token init failure This change causes us to restart entd if token initialization fails. The most common cause for token init to fail is a hardware timeout, which leaves the token in a state which we can't easily recover from. After this change (and changes in init and the ebuild), we will restart entd, detect and delete the broken token, and the user will be able to retry the initialization. BUG=None TEST=gmerge onto gadget, force a failure, and witness the recovery. Change-Id: Iaf7a8472392ffd928f3852262db49d378ca60fdd

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -13 lines)			Patch
M	base_policy/policy-utils.js	View	4 chunks	+11 lines, -2 lines	0 comments	Download
A	bin/fix_pkcs11_token.sh	View	1 chunk	+47 lines, -0 lines	1 comment	Download
M	reference_extension/client.js	View	6 chunks	+30 lines, -10 lines	0 comments	Download
M	reference_extension/options.html	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years, 4 months ago (2010-08-23 23:56:28 UTC) #3

and this is the nit

http://codereview.chromium.org/3107031/diff/1/3
File bin/fix_pkcs11_token.sh (right):

http://codereview.chromium.org/3107031/diff/1/3#newcode23
bin/fix_pkcs11_token.sh:23: rm -rf $USER_TOKEN_DIR/*
perhaps "$USER_TOKEN_DIR"/*

to be as consistent as you can?

Expand Messages | Collapse Messages