Issue 3107030: Address post-review comments on r56727.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3107030: Address post-review comments on r56727. (Closed)

Created:
10 years, 4 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, Mark Larson

Visibility:
Public.

Description

Address post-review comments on r56727. BUG=none TEST=none

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	net/base/ssl_config_service.h	View		2 chunks	+6 lines, -5 lines	2 comments	Download
	M	net/http/http_stream_request.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 4 months ago (2010-08-22 04:44:34 UTC) #2

LGTM.

http://codereview.chromium.org/3107030/diff/1/2
File net/base/ssl_config_service.h (right):

http://codereview.chromium.org/3107030/diff/1/2#newcode36
net/base/ssl_config_service.h:36: // True if we believe that this connection
might be MITM attacked. This
Should this say
  True if we allow this connection to be MITM attacked.
?

http://codereview.chromium.org/3107030/diff/1/2#newcode121
net/base/ssl_config_service.h:121: // Sets a global flag which causes
SetSSLConfigFlags to set the
Nit: SetSSLConfigFlags is an implementation detail (protected
method).

How about this?
    Sets a global flag which allows SSL connections to
    be MITM attacked.
or
    Allows SSL connections to be MITM attacked.

Expand Messages | Collapse Messages