Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 3107021: Convert FormatBytes to string16. (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, viettrungluu
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, ben+cc_chromium.org, Paul Godavari, darin-cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Convert FormatBytes to string16. I considered ASCII, but it's producing what is intended to be a human-readable string. For example, in theory the "bytes/s" annotation could be localized into a language where the "b" is non-ASCII. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56771

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -77 lines) Patch
M base/string_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/string_util.cc View 2 chunks +23 lines, -23 lines 0 comments Download
M base/string_util_unittest.cc View 2 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 2 chunks +5 lines, -6 lines 1 comment Download
M chrome/browser/download/download_util.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/gtk/gtk_chrome_cookie_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/appcache/view_appcache_internals_job.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
10 years, 4 months ago (2010-08-18 01:42:59 UTC) #1
Evan Martin
10 years, 4 months ago (2010-08-18 16:01:33 UTC) #2
viettrungluu
LGTM. http://codereview.chromium.org/3107021/diff/1/6 File chrome/browser/download/download_item_model.cc (right): http://codereview.chromium.org/3107021/diff/1/6#newcode44 chrome/browser/download/download_item_model.cc:44: base::i18n::GetDisplayStringInLTRDirectionality(&simple_total); I guess we really should make a ...
10 years, 4 months ago (2010-08-18 16:15:54 UTC) #3
Evan Martin
10 years, 4 months ago (2010-08-18 16:22:11 UTC) #4
On 2010/08/18 16:15:54, viettrungluu wrote:
> base::i18n::GetDisplayStringInLTRDirectionality(&simple_total);
> I guess we really should make a string16 version of this function....

Tony did!  This patch is based on seeing the conversions he had to do in his
change to fix it!

Powered by Google App Engine
This is Rietveld 408576698