Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: net/socket/socket_test_util.cc

Issue 3107013: Fix a bug in the mock sockets. For SSL sockets, when they were... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
===================================================================
--- net/socket/socket_test_util.cc (revision 56039)
+++ net/socket/socket_test_util.cc (working copy)
@@ -361,12 +361,12 @@
int rv = transport_->socket()->Connect(connect_callback);
if (rv == net::OK) {
delete connect_callback;
+ if (data_->connect.result == net::OK)
+ connected_ = true;
eroman 2010/08/21 02:48:09 It would be better to only set connected_ to true
if (data_->connect.async) {
RunCallbackAsync(callback, data_->connect.result);
return net::ERR_IO_PENDING;
}
- if (data_->connect.result == net::OK)
- connected_ = true;
return data_->connect.result;
}
return rv;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698