Fix a bug in the mock sockets. For SSL sockets, when they were...

Fix a bug in the mock sockets.  For SSL sockets, when they were
completing the connect asynchronously, we never set the connected_
flag to true.  This is usually benign, because we don't often
check the flag.

BUG=none
TEST=none




Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56219

[Ryan Hamilton, 2010-08-16 18:58:38]

LGTM.  This fix resolved the problem I was having in my Https proxy tests. 
Awesome!

[eroman, 2010-08-21 02:48:09]

apologies this got buried in my review queue and didn't notice it until now.

looks good, but I don't think this is the best fix.

http://codereview.chromium.org/3107013/diff/1/2
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/3107013/diff/1/2#newcode365
net/socket/socket_test_util.cc:365: connected_ = true;
It would be better to only set connected_ to true right before we call the user
callback.

[Mike Belshe, 2010-08-21 03:14:20]

On 2010/08/21 02:48:09, eroman wrote:
> apologies this got buried in my review queue and didn't notice it until now.
> 
> looks good, but I don't think this is the best fix.
> 
> http://codereview.chromium.org/3107013/diff/1/2
> File net/socket/socket_test_util.cc (right):
> 
> http://codereview.chromium.org/3107013/diff/1/2#newcode365
> net/socket/socket_test_util.cc:365: connected_ = true;
> It would be better to only set connected_ to true right before we call the
user
> callback.

I don't think so - the MockSocket is trying to simulate the real network, and
the real network behaves like this code does.  First, we hit the IO which may
cause the socket to be connected, an then, sometime later, the callback fires
notifying the delegate that hey - we're connected...  So this is simulating
exactly that condition.

Obviously the gap between actually connecting and the user-callback may vary on
different types of sockets.