Issue 3107008: sync: Add sessions to protocol and chromiumsync python test server.

Issue 3107008: sync: Add sessions to protocol and chromiumsync python test server. (Closed)

Created:
10 years, 4 months ago by jerrica

Modified:
9 years, 7 months ago

Reviewers:
Raghu Simha, tim (not reviewing)

CC:
chromium-reviews, cbentzel+watch_chromium.org, idana, ben+cc_chromium.org, ncarter (slow), darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

sync: Add sessions to protocol and chromiumsync python test server. BUG=30519 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55973

Patch Set 4 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -6 lines)			Patch
A	chrome/browser/sync/protocol/session_specifics.proto	View		1 chunk	+91 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/protocol/sync_proto.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/testserver/chromiumsync.py	View	1 2 3	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Raghu Simha

Changes to chromiumsync.py LGTM, after minor fix. http://codereview.chromium.org/3107008/diff/4001/5004 File net/tools/testserver/chromiumsync.py (right): http://codereview.chromium.org/3107008/diff/4001/5004#newcode170 net/tools/testserver/chromiumsync.py:170: # TODO(rsimha): ...

10 years, 4 months ago (2010-08-12 23:44:52 UTC) #2

jerrica

http://codereview.chromium.org/3107008/diff/4001/5004 File net/tools/testserver/chromiumsync.py (right): http://codereview.chromium.org/3107008/diff/4001/5004#newcode170 net/tools/testserver/chromiumsync.py:170: # TODO(rsimha): Disabled since the protocol does not support ...

10 years, 4 months ago (2010-08-12 23:50:02 UTC) #3

tim (not reviewing)

10 years, 4 months ago (2010-08-13 00:10:41 UTC) #4

On 2010/08/12 23:50:02, jerrica wrote:
> http://codereview.chromium.org/3107008/diff/4001/5004
> File net/tools/testserver/chromiumsync.py (right):
> 
> http://codereview.chromium.org/3107008/diff/4001/5004#newcode170
> net/tools/testserver/chromiumsync.py:170: # TODO(rsimha): Disabled since the
> protocol does not support it yet.
> On 2010/08/12 23:44:52, rsimha wrote:
> > This TODO can be removed, right?
> 
> Done.

LGTM

Expand Messages | Collapse Messages