Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: base/logging.cc

Issue 3106032: base: Disallow mixing NDEBUG settings in logging.{h,cc}. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: restore TODO Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index 2d6191034dc752155d80f0170cfe49d6e25ab6f1..f90a3695f2bd55be2554ece0617edc5ec12c9796 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -82,10 +82,8 @@ const int kAlwaysPrintErrorLevel = LOG_ERROR;
// will be lazily initialized to the default value when it is
// first needed.
#if defined(OS_WIN)
-typedef wchar_t PathChar;
typedef std::wstring PathString;
#else
-typedef char PathChar;
typedef std::string PathString;
#endif
PathString* log_file_name = NULL;
@@ -248,8 +246,10 @@ void InitLogMutex() {
#endif
}
-void InitLogging(const PathChar* new_log_file, LoggingDestination logging_dest,
- LogLockingState lock_log, OldFileDeletionState delete_old) {
+void BaseInitLoggingImpl(const PathChar* new_log_file,
+ LoggingDestination logging_dest,
+ LogLockingState lock_log,
+ OldFileDeletionState delete_old) {
g_enable_dcheck =
CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableDCHECK);
« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698