New first run experience for Linux.

New first run experience for Linux.

We first show a search engine choice dialog (basically matches windows) but also (in the google chrome case) show a second dialog with the "make chrome the default browser" and "report crashes?" checkboxes. In the chromium case, we don't show the second dialog because it would have a single checkbox (no crash reporting in chromium), and that checkbox is covered by an infobar anyway.

In Chrome, the search engines have image logos. In chromium, they only have plain text logos.

We also no longer show the first run bubble.

BUG=49705
TEST=manual (Chrome and Chromium)

TODO:
- skip the search engine choice when there are no suggested search engines
- show the default search if it's not in the first 3 search engines list
- randomize the search engines list (sometimes)
- remove first run bubble code

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57109

[Evan Stade, 2010-08-20 22:06:47]

http://www/~estade/no_crawl/chromium_fr.png
http://www/~estade/no_crawl/chrome_fr.png

[Evan Stade, 2010-08-20 22:09:37]

hmm, the chrome screenshot I posted is a little out of date in a couple ways,
but rebuilding everything with branding=Chrome takes a while, so just take it as
a guideline I guess.

[Elliot Glaysher, 2010-08-20 22:32:08]

OK

On Fri, Aug 20, 2010 at 3:09 PM,  <estade@chromium.org> wrote:
> hmm, the chrome screenshot I posted is a little out of date in a couple
> ways,
> but rebuilding everything with branding=Chrome takes a while, so just take
> it as
> a guideline I guess.
>
> http://codereview.chromium.org/3106031/show
>

[Evan Martin, 2010-08-20 23:21:42]

I spaced out on the thread.  Why not only show one dialog with both the searches
and the checkboxes?

[Evan Stade, 2010-08-20 23:25:13]

we want to force a choice, so I had made the "Start Chrome" button greyed out
until the user chose a search engine. The UI leads don't think it's obvious how
to make the button un-greyed out (i.e. by choosing one of the search engines) so
they said to do this for now.

[Nico, 2010-08-21 00:57:44]

See issue 47651 comment 8 for how this is supposed to work: The page you
download chrome from is supposed to have a checkbox for default browser.

[Evan Martin, 2010-08-21 22:14:22]

http://codereview.chromium.org/3106031/diff/2001/3001
File chrome/browser/gtk/first_run_dialog.cc (right):

http://codereview.chromium.org/3106031/diff/2001/3001#newcode107
chrome/browser/gtk/first_run_dialog.cc:107:
l10n_util::GetStringUTF8(IDS_FIRSTRUN_DLG_TITLE).c_str());
Should this be a dialog?  I think that gets some additional WM hints that
control how it's positioned in some window managers.  It matters more if this
dialog is floating above an existing window, though...

http://codereview.chromium.org/3106031/diff/2001/3001#newcode149
chrome/browser/gtk/first_run_dialog.cc:149:
gtk_widget_set_size_request(explanation, 3 * 180 - 1, -1);
Where does 3 * 180 - 1 come from?  Should it be a named constant?

http://codereview.chromium.org/3106031/diff/2001/3001#newcode153
chrome/browser/gtk/first_run_dialog.cc:153: search_engine_hbox_ =
gtk_hbox_new(FALSE, 6);
I guess there's some name for the 6 here already.

http://codereview.chromium.org/3106031/diff/2001/3001#newcode186
chrome/browser/gtk/first_run_dialog.cc:186: // manually:
I wonder if this comment still applies.

http://codereview.chromium.org/3106031/diff/2001/3001#newcode250
chrome/browser/gtk/first_run_dialog.cc:250: #if defined(GOOGLE_CHROME_BUILD)
Maybe stick a comment in here about how we don't have the images in non-Google
Chrome builds.

http://codereview.chromium.org/3106031/diff/2001/3001#newcode305
chrome/browser/gtk/first_run_dialog.cc:305: if (dialog_)
When is this not true?

http://codereview.chromium.org/3106031/diff/2001/3002
File chrome/browser/gtk/first_run_dialog.h (right):

http://codereview.chromium.org/3106031/diff/2001/3002#newcode48
chrome/browser/gtk/first_run_dialog.h:48: // FIXME
Probably intend to fix these, no?  :)

[Evan Stade, 2010-08-23 18:23:17]

On 2010/08/21 00:57:44, Nico wrote:
> See issue 47651 comment 8 for how this is supposed to work: The page you
> download chrome from is supposed to have a checkbox for default browser.

yea, I realize that, but it's not what we're doing on Linux. This changelist is
the result of a long thread with the UI leads.

http://codereview.chromium.org/3106031/diff/2001/3001
File chrome/browser/gtk/first_run_dialog.cc (right):

http://codereview.chromium.org/3106031/diff/2001/3001#newcode107
chrome/browser/gtk/first_run_dialog.cc:107:
l10n_util::GetStringUTF8(IDS_FIRSTRUN_DLG_TITLE).c_str());
On 2010/08/21 22:14:22, Evan Martin wrote:
> Should this be a dialog?  I think that gets some additional WM hints that
> control how it's positioned in some window managers.  It matters more if this
> dialog is floating above an existing window, though...

yea. Modality and transience don't really make sense in the case where it's the
only app window anyway.

The reason for line 108 is that it makes it more dialog-like (e.g. in xmonad
it's a floating window, rather than a tiled window, by default).

http://codereview.chromium.org/3106031/diff/2001/3001#newcode149
chrome/browser/gtk/first_run_dialog.cc:149:
gtk_widget_set_size_request(explanation, 3 * 180 - 1, -1);
On 2010/08/21 22:14:22, Evan Martin wrote:
> Where does 3 * 180 - 1 come from?  Should it be a named constant?

yea.. will fix. 180 is the width of a single image, and the -1 is necessary to
make the label draw properly although I didn't delve too deeply into why.

http://codereview.chromium.org/3106031/diff/2001/3001#newcode153
chrome/browser/gtk/first_run_dialog.cc:153: search_engine_hbox_ =
gtk_hbox_new(FALSE, 6);
On 2010/08/21 22:14:22, Evan Martin wrote:
> I guess there's some name for the 6 here already.

think I took it from the views code, i'll give it a name

http://codereview.chromium.org/3106031/diff/2001/3001#newcode186
chrome/browser/gtk/first_run_dialog.cc:186: // manually:
now that I think about it, I think what makes the most sense is to use a
resource like this but use it to size the text label

http://codereview.chromium.org/3106031/diff/2001/3001#newcode250
chrome/browser/gtk/first_run_dialog.cc:250: #if defined(GOOGLE_CHROME_BUILD)
On 2010/08/21 22:14:22, Evan Martin wrote:
> Maybe stick a comment in here about how we don't have the images in non-Google
> Chrome builds.

Done.

http://codereview.chromium.org/3106031/diff/2001/3001#newcode305
chrome/browser/gtk/first_run_dialog.cc:305: if (dialog_)
On 2010/08/21 22:14:22, Evan Martin wrote:
> When is this not true?

in chromium, we don't ever make dialog_ (see ShowDialog())

[Nico, 2010-08-23 18:32:15]

On Mon, Aug 23, 2010 at 11:23 AM,  <estade@chromium.org> wrote:
> On 2010/08/21 00:57:44, Nico wrote:
>>
>> See issue 47651 comment 8 for how this is supposed to work: The page you
>> download chrome from is supposed to have a checkbox for default browser.
>
> yea, I realize that, but it's not what we're doing on Linux. This changelist
> is
> the result of a long thread with the UI leads.

I see. Is the conclusion from that thread somewhere in the issue tracker?

>
>
> http://codereview.chromium.org/3106031/diff/2001/3001
> File chrome/browser/gtk/first_run_dialog.cc (right):
>
> http://codereview.chromium.org/3106031/diff/2001/3001#newcode107
> chrome/browser/gtk/first_run_dialog.cc:107:
> l10n_util::GetStringUTF8(IDS_FIRSTRUN_DLG_TITLE).c_str());
> On 2010/08/21 22:14:22, Evan Martin wrote:
>>
>> Should this be a dialog?  I think that gets some additional WM hints
>
> that
>>
>> control how it's positioned in some window managers.  It matters more
>
> if this
>>
>> dialog is floating above an existing window, though...
>
> yea. Modality and transience don't really make sense in the case where
> it's the only app window anyway.
>
> The reason for line 108 is that it makes it more dialog-like (e.g. in
> xmonad it's a floating window, rather than a tiled window, by default).
>
> http://codereview.chromium.org/3106031/diff/2001/3001#newcode149
> chrome/browser/gtk/first_run_dialog.cc:149:
> gtk_widget_set_size_request(explanation, 3 * 180 - 1, -1);
> On 2010/08/21 22:14:22, Evan Martin wrote:
>>
>> Where does 3 * 180 - 1 come from?  Should it be a named constant?
>
> yea.. will fix. 180 is the width of a single image, and the -1 is
> necessary to make the label draw properly although I didn't delve too
> deeply into why.
>
> http://codereview.chromium.org/3106031/diff/2001/3001#newcode153
> chrome/browser/gtk/first_run_dialog.cc:153: search_engine_hbox_ =
> gtk_hbox_new(FALSE, 6);
> On 2010/08/21 22:14:22, Evan Martin wrote:
>>
>> I guess there's some name for the 6 here already.
>
> think I took it from the views code, i'll give it a name
>
> http://codereview.chromium.org/3106031/diff/2001/3001#newcode186
> chrome/browser/gtk/first_run_dialog.cc:186: // manually:
> now that I think about it, I think what makes the most sense is to use a
> resource like this but use it to size the text label
>
> http://codereview.chromium.org/3106031/diff/2001/3001#newcode250
> chrome/browser/gtk/first_run_dialog.cc:250: #if
> defined(GOOGLE_CHROME_BUILD)
> On 2010/08/21 22:14:22, Evan Martin wrote:
>>
>> Maybe stick a comment in here about how we don't have the images in
>
> non-Google
>>
>> Chrome builds.
>
> Done.
>
> http://codereview.chromium.org/3106031/diff/2001/3001#newcode305
> chrome/browser/gtk/first_run_dialog.cc:305: if (dialog_)
> On 2010/08/21 22:14:22, Evan Martin wrote:
>>
>> When is this not true?
>
> in chromium, we don't ever make dialog_ (see ShowDialog())
>
> http://codereview.chromium.org/3106031/show
>

[Evan Stade, 2010-08-23 19:38:30]

updated

[Evan Martin, 2010-08-23 19:44:11]

LG

http://codereview.chromium.org/3106031/diff/16001/17002
File chrome/browser/gtk/first_run_dialog.h (right):

http://codereview.chromium.org/3106031/diff/16001/17002#newcode48
chrome/browser/gtk/first_run_dialog.h:48: // The search engine choice window.
This is create and shown before |dialog_|.
*created