Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 3106018: Reapplies all the IPC system work (reverts the revert r56272). (Closed)

Created:
10 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
huanr, Matt Perry
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, native-client-reviews_googlegroups.com, stuartmorgan+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Reapplies all the IPC system work (reverts the revert r56272). That patch wasn't what caused the regression in the page cycler. BUG=51411, 52103 TEST=still compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2890 lines, -1556 lines) Patch
M base/tuple.h View 10 chunks +156 lines, -108 lines 0 comments Download
M chrome/browser/extensions/extension_messages_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +6 lines, -1 line 0 comments Download
A chrome/browser/importer/importer_messages.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/visitedlink_event_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 7 chunks +13 lines, -4 lines 0 comments Download
M chrome/common/common_param_traits.h View 5 chunks +5 lines, -40 lines 0 comments Download
M chrome/common/common_param_traits.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/common/devtools_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/common/gpu_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/common/nacl_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/nacl_messages_internal.h View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/plugin_messages.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 16 chunks +90 lines, -792 lines 0 comments Download
A chrome/common/render_messages.cc View 1 chunk +923 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/common/render_messages_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/resource_dispatcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/service_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/common/utility_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/webkit_param_traits.h View 4 chunks +23 lines, -131 lines 0 comments Download
A chrome/common/webkit_param_traits.cc View 1 chunk +170 lines, -0 lines 0 comments Download
A chrome/common/worker_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/blocked_plugin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/indexed_db_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/pepper_devices.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_widget.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webcookiejar_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/automation/automation_messages.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
A ipc/ipc_message_impl_macros.h View 1 chunk +674 lines, -0 lines 0 comments Download
M ipc/ipc_message_macros.h View 40 chunks +348 lines, -285 lines 0 comments Download
M ipc/ipc_message_utils.h View 13 chunks +110 lines, -181 lines 0 comments Download
M ipc/ipc_message_utils.cc View 3 chunks +127 lines, -0 lines 0 comments Download
A ipc/ipc_message_utils_impl.h View 1 chunk +60 lines, -0 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/pdf_ps_metafile_cairo.h View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/pdf_ps_metafile_cairo.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
(Somebody to rubberstamp this. No code changes from yesterday's revert.)
10 years, 4 months ago (2010-08-17 17:36:09 UTC) #1
Matt Perry
Hooray! lgtm
10 years, 4 months ago (2010-08-17 17:52:52 UTC) #2
huanr
10 years, 4 months ago (2010-08-17 17:55:40 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698