Enforce Terminate on Heap Corruption in most of our executable on Windows XP ...

Enforce Terminate on Heap Corruption in most of our executable on Windows XP SP3 or Vista.
This won't submit the crash dump but it's still better than nothing.

Fix broken alignment on test_shell_main.cc.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2546

[Nicolas Sylvain, 2008-09-17 21:51:52]

Be sure to submit this when the tree is idle so you see how many failures you
need to fix before submitting it for real :)

And for the nit below, maybe you can return a bool, and also dcheck inside the
function of it fails.

http://codereview.chromium.org/3105/diff/1/8
File base/process_util_win.cc (right):

http://codereview.chromium.org/3105/diff/1/8#newcode597
Line 597: void EnableTerminationOnHeapCorruption() {
It would be great to return a bool here.

[Nicolas Sylvain, 2008-09-17 21:53:23]

3 more questions

1. Is it going to impact the speed?

2. How can we make it work with breakpad?

3. Would it kick in before breakpad if a heap corruption would cause a crash?

Nicolas

On 2008/09/17 21:51:52, Nicolas Sylvain wrote:
> Be sure to submit this when the tree is idle so you see how many failures you
> need to fix before submitting it for real :)
> 
> And for the nit below, maybe you can return a bool, and also dcheck inside the
> function of it fails.
> 
> http://codereview.chromium.org/3105/diff/1/8
> File base/process_util_win.cc (right):
> 
> http://codereview.chromium.org/3105/diff/1/8#newcode597
> Line 597: void EnableTerminationOnHeapCorruption() {
> It would be great to return a bool here.

[M-A Ruel, 2008-09-18 19:42:46]

2008/9/17  <nsylvain@chromium.org>:
> 1. Is it going to impact the speed?

Not significantly from what I read. In any case, we'll see on the perf stats.

> 2. How can we make it work with breakpad?

I don't know yet.
http://code.google.com/p/chromium/issues/detail?id=2515

> 3. Would it kick in before breakpad if a heap corruption would cause a
> crash?

I don't think breakpad has any chance right now.

>> http://codereview.chromium.org/3105/diff/1/8#newcode597
>> Line 597: void EnableTerminationOnHeapCorruption() {
>> It would be great to return a bool here.

It'll fail on Windows XP SP2 and lower. And in any case we can't do
anything about it. I can return a bool if you _really_ care. But
adding a DCHECK() is a really bad idea.

[Nicolas Sylvain, 2008-09-19 19:38:55]

From a security perspective i'm OK with this change.  but i'm afraid it's going
to make it harder to track some bugs if we don't have crash dumps.

I guess security is first, so LGTM.

Please submit when the tree is idle. I,m sure it's going to turn red!