src/x64/codegen-x64.cc - Issue 3104027: Fix bug in 64 bit codegen causing us to always go slowcase in apply....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 3104027: Fix bug in 64 bit codegen causing us to always go slowcase in apply.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

===================================================================

--- src/x64/codegen-x64.cc (revision 5316)

+++ src/x64/codegen-x64.cc (working copy)

@@ -2619,7 +2619,7 @@

__ movq(rcx, FieldOperand(rax, JSFunction::kCodeEntryOffset));

__ subq(rcx, Immediate(Code::kHeaderSize - kHeapObjectTag));

Handle<Code> apply_code(Builtins::builtin(Builtins::FunctionApply));

- __ Cmp(FieldOperand(rcx, SharedFunctionInfo::kCodeOffset), apply_code);

+ __ Cmp(rcx, apply_code);

__ j(not_equal, &build_args);

// Check that applicand is a function.

« no previous file with comments | « no previous file | no next file » | no next file with comments »