Issue 3104027: Fix bug in 64 bit codegen causing us to always go slowcase in apply....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3104027: Fix bug in 64 bit codegen causing us to always go slowcase in apply.... (Closed)

Created:
10 years, 4 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in 64 bit codegen causing us to always go slowcase in apply. After introducing the direct instruction pointer in functions the CallApplyLazy method was changed on all platforms. The change made to the 64 bit version was wrong, not using the right operand for the code comparisons always forcing us into slow case. Committed: http://code.google.com/p/v8/source/detail?r=5317

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/x64/codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages