Issue 3104022: Move nsNSSCertTrust from chrome/third_party to net/third_party.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3104022: Move nsNSSCertTrust from chrome/third_party to net/third_party. (Closed)

Created:
10 years, 4 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Move nsNSSCertTrust from chrome/third_party to net/third_party. BUG=19991 TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56799

Patch Set 1 #

Total comments: 1

Patch Set 2 : header order #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/net.gyp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
A +	net/third_party/mozilla_security_manager/nsNSSCertTrust.h	View		2 chunks	+7 lines, -3 lines	0 comments	Download
A +	net/third_party/mozilla_security_manager/nsNSSCertTrust.cpp	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

Going to use this from some stuff in net/third_party/mozilla_security_manager, so have to move it under ...

10 years, 4 months ago (2010-08-19 22:32:12 UTC) #1

wtc

10 years, 4 months ago (2010-08-19 22:47:28 UTC) #2

LGTM.

Probably can reference the Linux cert manager bug in the
BUG= field, if this is related to that work.

http://codereview.chromium.org/3104022/diff/1/3
File chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp (right):

http://codereview.chromium.org/3104022/diff/1/3#newcode51
chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp:51: #include
"net/third_party/mozilla_security_manager/nsNSSCertTrust.h"
Nit: list this header last because the pathname changed.

Expand Messages | Collapse Messages