Refactor -- make ui passive watcher, control a passive test list.

Refactor -- make ui passive watcher, control a passive test list.

Lifted control logic into a library and made the user-editable
control file into only a simple test, with no executable code.

Eliminated all runtime non-startup communication between the ui
and the control process.

Generally made code more self-documenting.

BUG=chrome-os-partner:537, 334
Change-Id: Ia80723585ba4dfbea11d24374467e0d57bc73469

[Tammo Spalink, 2010-08-19 08:46:56]

Sorry about the size of this CL.  The goal was to clean up the control file, and
there did not seem an obvious way to do that in pieces.

[Tammo Spalink, 2010-08-19 08:50:06]

Probably the best place to start looking at stuff is the control.base file
(which is the actual goal of this refactoring), and then see how it gets
included by control, and go from there.

[Tammo Spalink, 2010-08-20 10:34:28]

reviews, anyone?  pretty please?

[Tammo Spalink, 2010-08-20 10:36:46]

this CL does bad things to the hw-qual-id gathering that used to happen ; my
plan is to follow up with a more general mechanism to allow all tests to
contribute to accumulated state that all later tests will see

[Tom Wai-Hong Tam, 2010-08-20 22:14:20]

Cool. It is more easy to read.

http://codereview.chromium.org/3104020/diff/4001/5001
File client/bin/factory.py (right):

http://codereview.chromium.org/3104020/diff/4001/5001#newcode322
client/bin/factory.py:322: with open(RESULT_FILE_PATH, 'w') as file:
Seems that RESULT_FILE_PATH is not to store test result. It keeps the next test
an user manually require to switch. How about to change to other name instead of
"result"?

http://codereview.chromium.org/3104020/diff/4001/5001#newcode328
client/bin/factory.py:328: self.explicit_switch = None
Please add a comment on explicit_switch. What it means?

http://codereview.chromium.org/3104020/diff/4001/5002
File client/bin/factory_ui (right):

http://codereview.chromium.org/3104020/diff/4001/5002#newcode203
client/bin/factory_ui:203: or self._empty_test_widget)
Could you make some comments on the above logic?

http://codereview.chromium.org/3104020/diff/4001/5004
File client/site_tests/suite_Factory/control (right):

http://codereview.chromium.org/3104020/diff/4001/5004#newcode45
client/site_tests/suite_Factory/control:45: execfile(job.autodir +
'/site_tests/suite_Factory/control.base')
Actually control.base is not a runnable autotest control file. How about rename
it to something like factory_settings or factory_config?

[tbroch1, 2010-08-20 22:43:32]

http://codereview.chromium.org/3104020/diff/4001/5001
File client/bin/factory.py (right):

http://codereview.chromium.org/3104020/diff/4001/5001#newcode206
client/bin/factory.py:206: tag_prefix, _, count = tag.rpartition('_')
I had problems here with factory_ExternalStorage and that it internally calls
hardware_StorageFIO.

To repro, just run each using hotkey trigger.  I patched your CL onto
http://build.chromium.org/buildbot/chromiumos/builders/x86%20generic%20binary...
factory_image

[Tammo Spalink, 2010-08-23 10:50:46]

http://codereview.chromium.org/3104020/diff/4001/5001
File client/bin/factory.py (right):

http://codereview.chromium.org/3104020/diff/4001/5001#newcode206
client/bin/factory.py:206: tag_prefix, _, count = tag.rpartition('_')
Fixed.

On 2010/08/20 22:43:32, tbroch1 wrote:
> I had problems here with factory_ExternalStorage and that it internally calls
> hardware_StorageFIO.
> 
> To repro, just run each using hotkey trigger.  I patched your CL onto
>
http://build.chromium.org/buildbot/chromiumos/builders/x86%2520generic%2520bi...
> factory_image
>

http://codereview.chromium.org/3104020/diff/4001/5001#newcode322
client/bin/factory.py:322: with open(RESULT_FILE_PATH, 'w') as file:
got rid of this file

On 2010/08/20 22:14:20, Tom Wai-Hong Tam wrote:
> Seems that RESULT_FILE_PATH is not to store test result. It keeps the next
test
> an user manually require to switch. How about to change to other name instead
of
> "result"?

http://codereview.chromium.org/3104020/diff/4001/5001#newcode328
client/bin/factory.py:328: self.explicit_switch = None
renamed, hopefully more obvious -- longer term, i want the UI to be more like a
window manager and capture these directly and this will go away

On 2010/08/20 22:14:20, Tom Wai-Hong Tam wrote:
> Please add a comment on explicit_switch. What it means?

http://codereview.chromium.org/3104020/diff/4001/5002
File client/bin/factory_ui (right):

http://codereview.chromium.org/3104020/diff/4001/5002#newcode203
client/bin/factory_ui:203: or self._empty_test_widget)
On 2010/08/20 22:14:20, Tom Wai-Hong Tam wrote:
> Could you make some comments on the above logic?

Done.

http://codereview.chromium.org/3104020/diff/4001/5004
File client/site_tests/suite_Factory/control (right):

http://codereview.chromium.org/3104020/diff/4001/5004#newcode45
client/site_tests/suite_Factory/control:45: execfile(job.autodir +
'/site_tests/suite_Factory/control.base')
On 2010/08/20 22:14:20, Tom Wai-Hong Tam wrote:
> Actually control.base is not a runnable autotest control file. How about
rename
> it to something like factory_settings or factory_config?

Done.

[Tom Wai-Hong Tam, 2010-08-23 20:55:07]

LGTM