Issue 3104011: Add Mac GPU logging code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3104011: Add Mac GPU logging code. (Closed)

Created:
10 years, 4 months ago by mafv

Modified:
9 years, 6 months ago

Reviewers:
rpetterson

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add Mac GPU logging code. Add separate GL version field. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56957

Patch Set 9 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -8 lines)			Patch
M	chrome/common/gpu_info.h	View	3 4	1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome/common/gpu_info.cc	View	3 4	2 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/common/gpu_messages.h	View	3 4	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/common/gpu_messages_unittest.cc	View	3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/gpu/gpu_info_collector_mac.mm	View	1 2 3 4	1 chunk	+121 lines, -1 line	0 comments	Download
M	chrome/gpu/gpu_info_collector_win.cc	View	6 7	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rpetterson

One small question. Otherwise, LGTM. http://codereview.chromium.org/3104011/diff/3001/4001 File chrome/gpu/gpu_info_collector_mac.mm (right): http://codereview.chromium.org/3104011/diff/3001/4001#newcode121 chrome/gpu/gpu_info_collector_mac.mm:121: pixel_shader_version, vertex_shader_version); Is vertex_shader_version ...

10 years, 4 months ago (2010-08-16 22:59:15 UTC) #2

mafv

OK - now set to the same as the other shader version - OpenGL does ...

10 years, 4 months ago (2010-08-20 21:22:54 UTC) #3

Cool. LGTM.

Expand Messages | Collapse Messages

Issue 3104011: Add Mac GPU logging code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Messages