Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5985)

Unified Diff: chrome/browser/dom_ui/history_ui.cc

Issue 31014: Port DictionaryValue to use string16 instead of wstring. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/dom_ui.cc ('k') | chrome/browser/dom_ui/new_tab_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/history_ui.cc
===================================================================
--- chrome/browser/dom_ui/history_ui.cc (revision 10828)
+++ chrome/browser/dom_ui/history_ui.cc (working copy)
@@ -49,32 +49,34 @@
void HistoryUIHTMLSource::StartDataRequest(const std::string& path,
int request_id) {
DictionaryValue localized_strings;
- localized_strings.SetString(L"title",
- l10n_util::GetString(IDS_HISTORY_TITLE));
- localized_strings.SetString(L"loading",
- l10n_util::GetString(IDS_HISTORY_LOADING));
- localized_strings.SetString(L"newest",
- l10n_util::GetString(IDS_HISTORY_NEWEST));
- localized_strings.SetString(L"newer",
- l10n_util::GetString(IDS_HISTORY_NEWER));
- localized_strings.SetString(L"older",
- l10n_util::GetString(IDS_HISTORY_OLDER));
- localized_strings.SetString(L"searchresultsfor",
- l10n_util::GetString(IDS_HISTORY_SEARCHRESULTSFOR));
- localized_strings.SetString(L"history",
- l10n_util::GetString(IDS_HISTORY_BROWSERESULTS));
- localized_strings.SetString(L"cont",
- l10n_util::GetString(IDS_HISTORY_CONTINUED));
- localized_strings.SetString(L"searchbutton",
- l10n_util::GetString(IDS_HISTORY_SEARCH_BUTTON));
- localized_strings.SetString(L"noresults",
- l10n_util::GetString(IDS_HISTORY_NO_RESULTS));
- localized_strings.SetString(L"noitems",
- l10n_util::GetString(IDS_HISTORY_NO_ITEMS));
- localized_strings.SetString(L"deleteday",
- l10n_util::GetString(IDS_HISTORY_DELETE_PRIOR_VISITS_LINK));
- localized_strings.SetString(L"deletedaywarning",
- l10n_util::GetString(IDS_HISTORY_DELETE_PRIOR_VISITS_WARNING));
+ localized_strings.SetString(ASCIIToUTF16("title"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_TITLE)));
+ localized_strings.SetString(ASCIIToUTF16("loading"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_LOADING)));
+ localized_strings.SetString(ASCIIToUTF16("newest"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_NEWEST)));
+ localized_strings.SetString(ASCIIToUTF16("newer"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_NEWER)));
+ localized_strings.SetString(ASCIIToUTF16("older"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_OLDER)));
+ localized_strings.SetString(ASCIIToUTF16("searchresultsfor"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_SEARCHRESULTSFOR)));
+ localized_strings.SetString(ASCIIToUTF16("history"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_BROWSERESULTS)));
+ localized_strings.SetString(ASCIIToUTF16("cont"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_CONTINUED)));
+ localized_strings.SetString(ASCIIToUTF16("searchbutton"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_SEARCH_BUTTON)));
+ localized_strings.SetString(ASCIIToUTF16("noresults"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_NO_RESULTS)));
+ localized_strings.SetString(ASCIIToUTF16("noitems"),
+ WideToUTF16Hack(l10n_util::GetString(IDS_HISTORY_NO_ITEMS)));
+ localized_strings.SetString(ASCIIToUTF16("deleteday"),
+ WideToUTF16Hack(
+ l10n_util::GetString(IDS_HISTORY_DELETE_PRIOR_VISITS_LINK)));
+ localized_strings.SetString(ASCIIToUTF16("deletedaywarning"),
+ WideToUTF16Hack(
+ l10n_util::GetString(IDS_HISTORY_DELETE_PRIOR_VISITS_WARNING)));
static const StringPiece history_html(
ResourceBundle::GetSharedInstance().GetRawDataResource(
@@ -226,7 +228,7 @@
SetURLAndTitle(page_value, page.title(), page.url());
// Need to pass the time in epoch time (fastest JS conversion).
- page_value->SetInteger(L"time",
+ page_value->SetInteger(ASCIIToUTF16("time"),
static_cast<int>(page.visit_time().ToTimeT()));
// Until we get some JS i18n infrastructure, we also need to
@@ -246,15 +248,19 @@
IDS_HISTORY_DATE_WITH_RELATIVE_TIME,
date_str, base::TimeFormatFriendlyDate(page.visit_time()));
}
- page_value->SetString(L"dateRelativeDay", date_str);
- page_value->SetString(L"dateTimeOfDay",
- base::TimeFormatTimeOfDay(page.visit_time()));
+ page_value->SetString(ASCIIToUTF16("dateRelativeDay"),
+ WideToUTF16Hack(date_str));
+ page_value->SetString(
+ ASCIIToUTF16("dateTimeOfDay"),
+ WideToUTF16Hack(base::TimeFormatTimeOfDay(page.visit_time())));
} else {
- page_value->SetString(L"dateShort",
- base::TimeFormatShortDate(page.visit_time()));
- page_value->SetString(L"snippet", page.snippet().text());
+ page_value->SetString(
+ ASCIIToUTF16("dateShort"),
+ WideToUTF16Hack(base::TimeFormatShortDate(page.visit_time())));
+ page_value->SetString(
+ ASCIIToUTF16("snippet"), WideToUTF16Hack(page.snippet().text()));
}
- page_value->SetBoolean(L"starred",
+ page_value->SetBoolean(ASCIIToUTF16("starred"),
dom_ui_->get_profile()->GetBookmarkModel()->IsBookmarked(page.url()));
results_value.Append(page_value);
}
« no previous file with comments | « chrome/browser/dom_ui/dom_ui.cc ('k') | chrome/browser/dom_ui/new_tab_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698