Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3718)

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 31014: Port DictionaryValue to use string16 instead of wstring. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_unittest.cc ('k') | chrome/browser/extensions/extensions_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service.cc
===================================================================
--- chrome/browser/extensions/extensions_service.cc (revision 10828)
+++ chrome/browser/extensions/extensions_service.cc (working copy)
@@ -402,14 +402,15 @@
// again later, checking it here allows us to skip some potentially expensive
// work.
std::string id;
- if (!manifest->GetString(Extension::kIdKey, &id)) {
+ if (!manifest->GetString(WideToUTF16Hack(Extension::kIdKey), &id)) {
ReportExtensionInstallError("missing id key");
return NULL;
}
FilePath dest_dir = install_directory_.AppendASCII(id.c_str());
if (file_util::PathExists(dest_dir)) {
std::string version;
- if (!manifest->GetString(Extension::kVersionKey, &version)) {
+ if (!manifest->GetString(WideToUTF16Hack(Extension::kVersionKey),
+ &version)) {
ReportExtensionInstallError("missing version key");
return NULL;
}
@@ -421,7 +422,8 @@
}
std::string zip_hash;
- if (!manifest->GetString(Extension::kZipHashKey, &zip_hash)) {
+ if (!manifest->GetString(WideToUTF16Hack(Extension::kZipHashKey),
+ &zip_hash)) {
ReportExtensionInstallError("missing zip_hash key");
return NULL;
}
« no previous file with comments | « chrome/browser/extensions/extension_unittest.cc ('k') | chrome/browser/extensions/extensions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698