Port DictionaryValue to use string16 instead of wstring.

Port DictionaryValue to use string16 instead of wstring.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10818

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10833

[dsh, 2009-02-26 23:09:53]

Since this is really tied into prefs, I'm going to do that next and get rid of
all the hack conversions in between those two.

[brettw, 2009-02-27 00:55:02]

http://codereview.chromium.org/31014/diff/1/5
File base/string_util.h (right):

http://codereview.chromium.org/31014/diff/1/5#newcode21
Line 21: # define LIT16(s) WideToUTF16(L##s)
This #define is a little scary because it actually results in different types on
Windows & Linux: wchar_t* or string16. This seems like it is prone to errors.

Darin & I talked about this for like 30 minutes (we were thinking of different
macros and helper functions), but decided that the best thing is to just do
ASCIIToUTF16, UTF8ToUTF16, or WideToUTF16 as required. In most cases it would be
ASCII.

http://codereview.chromium.org/31014/diff/1/5#newcode434
Line 434: bool StringToInt(const string16& input, int* output);
Are these necessary? It seems our wstring versions above should be used instead
of creating a new set of parallel functions that will never be cleaned up later.
Converting the W versions to 16 and using the "Hack" functions seems like the
best approach to me.

[jar (doing other things), 2009-02-28 00:05:10]

I'm hopeful that all the changes were perfect and mechanical.  If there is an
error, it would probably impact logs and correctness (ability to parse the
logs).

I'll try to merge the diff into a tree and run against a local UMA server to see
if it seems to send reasonable logs.

Please tell me when you're about closer to final (i.e., Darin and Brett being
happy for instance).  I'll watch for their approvals as well.

Thanks,

Jim

http://codereview.chromium.org/31014/diff/1/14
File chrome/browser/metrics/metrics_log.cc (right):

http://codereview.chromium.org/31014/diff/1/14#newcode589
Line 589: DCHECK(*i != LIT16("id"));
Please create a more readable name than LIT16.

[dsh, 2009-03-03 05:25:06]

I took out the macros. ;)

Sorry about the size.  And sorry to keep sending you the code reviews, Brett. 
If you can suggest anyone else, I'll happily rotate them around.

Thanks!

[jar (doing other things), 2009-03-03 06:05:05]

The changes to metrics_service.cc and metrics_log.cc LGTM.

[brettw, 2009-03-03 16:07:48]

LGTM with only one change.

http://codereview.chromium.org/31014/diff/3001/3012
File chrome/browser/metrics/metrics_service.cc (right):

http://codereview.chromium.org/31014/diff/3001/3012#newcode1678
Line 1678: string16 plugin_name16;
I don't think adding "16" at the end of this name helps anything. How about just
leaving it the same name as before.