First phase of migration to new indexed property query callbacks.

First phase of migration to new indexed property query callbacks.

Eventually indexed property query callbacks will return attributes
(as an integer) or an empty handle if property is not intercepted.

To gradually migrate to this new API, USE_NEW_QUERY_CALLBACK
macro would control if old or new style API is used.

So the migration plan is:

1) introduce new API which should be explictily enabled;
2) switch to new API defining USE_NEW_QUERY_CALLBACK before
include of <v8.h> (that would require changes to client code as well)
3) remove old API from v8
4) remove #define USE_NEW_QUERY_CALLBACK from clients.

BUG=http://code.google.com/p/v8/issues/detail?id=816

Committed: http://code.google.com/p/v8/source/detail?r=5228

[antonm, 2010-08-09 15:52:00]

Mads,

may you have a look?

It's just a variation of http://codereview.chromium.org/2576003/show with the
same migration plan.

[Mads Ager (chromium), 2010-08-10 08:47:48]

LGTM

http://codereview.chromium.org/3101001/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/3101001/diff/1/2#newcode1822
include/v8.h:1822: * The result is true if either boolean (true if property
exists and false
The result is true if either boolean ...
->
The result is either a boolean ...

http://codereview.chromium.org/3101001/diff/1/2#newcode2066
include/v8.h:2066: IndexedPropertyEnumerator enumerator,
Long line.

http://codereview.chromium.org/3101001/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/3101001/diff/1/4#newcode5836
src/objects.cc:5836: // Temporary complicated logic, would be removed soon.
Instead of writing that it will be removed soon, can you write that it will be
removed when then transition to the new signature for indexed query callbacks is
complete.

[antonm, 2010-08-10 10:05:07]

Thanks a lot for review, Mads.  Submitting.

http://codereview.chromium.org/3101001/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/3101001/diff/1/2#newcode1822
include/v8.h:1822: * The result is true if either boolean (true if property
exists and false
On 2010/08/10 08:47:49, Mads Ager wrote:
> The result is true if either boolean ...
> ->
> The result is either a boolean ...

Done.

http://codereview.chromium.org/3101001/diff/1/2#newcode2066
include/v8.h:2066: IndexedPropertyEnumerator enumerator,
On 2010/08/10 08:47:49, Mads Ager wrote:
> Long line.

Thanks.  The strange this is ./tools/presubmit.py didn't catch that.  I'll check
what happened.

http://codereview.chromium.org/3101001/diff/1/4
File src/objects.cc (right):

http://codereview.chromium.org/3101001/diff/1/4#newcode5836
src/objects.cc:5836: // Temporary complicated logic, would be removed soon.
On 2010/08/10 08:47:49, Mads Ager wrote:
> Instead of writing that it will be removed soon, can you write that it will be
> removed when then transition to the new signature for indexed query callbacks
is
> complete.

Done.