Issue 31010: Hook up inspector highlighting again. This time we use...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 31010: Hook up inspector highlighting again. This time we use... (Closed)

Created:
11 years, 10 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
dglazkov, pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Hook up inspector highlighting again. This time we use upstream's drawNodeHighlight methods. BUG=5178 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10497

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -31 lines)			Patch
M	webkit/glue/inspector_client_impl.h	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	webkit/glue/inspector_client_impl.cc	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	2 chunks	+0 lines, -7 lines	1 comment	Download
M	webkit/glue/webframe_impl.cc	View	4 chunks	+2 lines, -5 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

LGTM. http://codereview.chromium.org/31010/diff/1/4 File webkit/glue/inspector_client_impl.h (right): http://codereview.chromium.org/31010/diff/1/4#newcode50 Line 50: // The node selected in the web ...

11 years, 10 months ago (2009-02-26 18:17:00 UTC) #2

pfeldman

11 years, 9 months ago (2009-02-28 20:13:09 UTC) #3

http://codereview.chromium.org/31010/diff/1/5
File webkit/glue/webframe_impl.h (right):

http://codereview.chromium.org/31010/diff/1/5#newcode225
Line 225: void selectNodeFromInspector(WebCore::Node* node);
This one is no longer implemented.

Expand Messages | Collapse Messages